Skip to content

Use vectorized jacobian in Minimize Op #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Michal-Novomestsky
Copy link

@Michal-Novomestsky Michal-Novomestsky commented Aug 12, 2025

Refactors as part of pymc-devs/pymc-extras#532


📚 Documentation preview 📚: https://pytensor--1582.org.readthedocs.build/en/1582/

@Michal-Novomestsky
Copy link
Author

pre-commit.ci autofix

@ricardoV94 ricardoV94 changed the title Minimize jacobian refactors Use vectorized jacobian in Minimize Op Aug 14, 2025
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.54%. Comparing base (f9a3234) to head (ee37c24).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/tensor/basic.py 75.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (85.71%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1582   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files         230      230           
  Lines       53136    53140    +4     
  Branches     9448     9448           
=======================================
+ Hits        43329    43333    +4     
- Misses       7370     7371    +1     
+ Partials     2437     2436    -1     
Files with missing lines Coverage Δ
pytensor/tensor/optimize.py 87.30% <100.00%> (ø)
pytensor/tensor/basic.py 91.80% <75.00%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Michal-Novomestsky
Copy link
Author

pre-commit.ci autofix

@ricardoV94
Copy link
Member

Can you open an issue for the fact the optimization notebook now fails with these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants